mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 37703: Add docker exec command.
Date Tue, 01 Dec 2015 03:09:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37703/#review108445
-----------------------------------------------------------



src/tests/containerizer/docker_tests.cpp (line 297)
<https://reviews.apache.org/r/37703/#comment167905>

    This isn't enough still, when the future is ready doesn't mean the container is actually
running yet.
    
    What you could do is to run docker->inspect(containerName, Miliseconds(500)) and it
will retry inspect until it's running, then you AWAIT that inspect future.


- Timothy Chen


On Nov. 29, 2015, 4:37 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37703/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2015, 4:37 p.m.)
> 
> 
> Review request for mesos and Timothy Chen.
> 
> 
> Bugs: MESOS-3291
>     https://issues.apache.org/jira/browse/MESOS-3291
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add docker exec command.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.hpp 33d6fb3e82ff7328ad093648a45546a18ec7b8cb 
>   src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a 
>   src/tests/containerizer/docker_tests.cpp d9e1345aea0ef9db0e50360e3993ef2708970298 
> 
> Diff: https://reviews.apache.org/r/37703/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message