mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 40524: Used string directly in resources.cpp.
Date Tue, 01 Dec 2015 01:06:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40524/#review108430
-----------------------------------------------------------

Ship it!


This is some nice code cleanup, but isn't related to optimistic offers.  
Can you move it out of the review chain?  (We can review/commit it quicker separately.)

- Joseph Wu


On Nov. 24, 2015, 10:41 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40524/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2015, 10:41 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Klaus
Ma.
> 
> 
> Bugs: MESOS-3955
>     https://issues.apache.org/jira/browse/MESOS-3955
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Used string directly in resources.cpp.
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp b4abf5405039d7d0a5028ccf034ad2e9623d064c 
>   src/v1/resources.cpp 8488c318a987a150fc5fde26b54246e8effb0428 
> 
> Diff: https://reviews.apache.org/r/40524/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message