From reviews-return-14800-apmail-mesos-reviews-archive=mesos.apache.org@mesos.apache.org Thu Nov 12 18:10:35 2015 Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8DCB71883F for ; Thu, 12 Nov 2015 18:10:35 +0000 (UTC) Received: (qmail 4873 invoked by uid 500); 12 Nov 2015 18:10:35 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 4853 invoked by uid 500); 12 Nov 2015 18:10:35 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 4835 invoked by uid 99); 12 Nov 2015 18:10:34 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Nov 2015 18:10:34 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 715EF2C95EB; Thu, 12 Nov 2015 18:10:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2951490144478529746==" MIME-Version: 1.0 Subject: Re: Review Request 40225: Fixed the Review Board URL in the commit message; substituted subprocess.call_check() with subprocess.call(). From: "Artem Harutyunyan" To: "Joris Van Remoortere" , "Vinod Kone" , "Ben Mahler" , "Joseph Wu" Cc: "mesos" , "Artem Harutyunyan" Date: Thu, 12 Nov 2015 18:10:34 -0000 Message-ID: <20151112181034.1681.57911@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Artem Harutyunyan" X-ReviewGroup: mesos X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/40225/ X-Sender: "Artem Harutyunyan" References: <20151112180024.1681.28218@reviews.apache.org> In-Reply-To: <20151112180024.1681.28218@reviews.apache.org> Reply-To: "Artem Harutyunyan" X-ReviewRequest-Repository: mesos --===============2951490144478529746== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Nov. 12, 2015, 10 a.m., Vinod Kone wrote: > > support/apply-reviews.py, line 23 > > > > > > s/ui_// > > > > What's a UI URL? > > Artem Harutyunyan wrote: > BenM noticed that instead of putting the Review Board UI URL in the commit message (as in https://reviews.apache.org/r/40225/) we had a Review Board API URL there (as in https://reviews.apache.org/api/review-requests/40225/). RB mangled the second link, it should be https://reviews.apache.org/api/review-requests/40225/ Do you have a suggestion for a better name? - Artem ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40225/#review106276 ----------------------------------------------------------- On Nov. 12, 2015, 9:56 a.m., Artem Harutyunyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40225/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2015, 9:56 a.m.) > > > Review request for mesos, Ben Mahler, Joris Van Remoortere, Joseph Wu, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Adjusted Review Board URL in comment. > > > Diffs > ----- > > support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 > > Diff: https://reviews.apache.org/r/40225/diff/ > > > Testing > ------- > > > Thanks, > > Artem Harutyunyan > > --===============2951490144478529746==--