mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Mann" <>
Subject Re: Review Request 39988: [4/5] Added authorization for dynamic reservation master endpoints.
Date Mon, 30 Nov 2015 20:46:19 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 30, 2015, 8:46 p.m.)

Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff.


Refactored validation into master's authorization helpers.

Bugs: MESOS-3062

Repository: mesos


Added authorization for dynamic reservation master endpoints.
Note: this review is continued from

Diffs (updated)

  src/master/http.cpp 9d729ef7f7d7ad6185934648f833e4f8a4f0a123 
  src/master/master.hpp 96951e766de32842197506504e5ac67a2caa3efe 
  src/tests/reservation_endpoints_tests.cpp f30ff8bc6a3e9773437fa7fd7c8f569b7d7e2d9d 



This is the fourth in a chain of 5 patches. Added new reservation endpoints tests to validate
authorization of reserve and unreserve operations using ACLs. `make check` was run to test
after all patches were applied.


Greg Mann

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message