mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Downes" <ian.dow...@gmail.com>
Subject Re: Review Request 39635: FreeBSD: Enable libprocess build and disable failing test
Date Mon, 30 Nov 2015 20:10:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39635/#review108381
-----------------------------------------------------------

Ship it!


Minor nits on comments. Will make the changes myself when I commit. Thanks!


3rdparty/libprocess/3rdparty/Makefile.am (line 243)
<https://reviews.apache.org/r/39635/#comment167818>

    Full stop.



3rdparty/libprocess/configure.ac (line 835)
<https://reviews.apache.org/r/39635/#comment167817>

    Full stop.



3rdparty/libprocess/src/tests/http_tests.cpp (line 897)
<https://reviews.apache.org/r/39635/#comment167819>

    Full stop.


- Ian Downes


On Nov. 27, 2015, 8:26 p.m., David Forsythe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39635/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2015, 8:26 p.m.)
> 
> 
> Review request for mesos and Ian Downes.
> 
> 
> Bugs: MESOS-1563
>     https://issues.apache.org/jira/browse/MESOS-1563
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> FreeBSD: Enable libprocess build and disable failing test
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/Makefile.am 0adbe539afaf683e4a85582463a2930049a63998 
>   3rdparty/libprocess/configure.ac 40801653a7fb9a943dfe33913161d28ef24040c3 
>   3rdparty/libprocess/src/config.hpp 8444a6018f9bc911d59a751b5a763f73d86ab1e6 
>   3rdparty/libprocess/src/tests/http_tests.cpp 2de75ca1c7e224c36b534c368e7379dc158aa5bb

> 
> Diff: https://reviews.apache.org/r/39635/diff/
> 
> 
> Testing
> -------
> 
> make check on ubuntu
> 
> 
> Thanks,
> 
> David Forsythe
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message