mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 40756: Updated codebase to use `nonRevocable()` where appropriate.
Date Mon, 30 Nov 2015 10:46:38 GMT


> On Nov. 28, 2015, 3:39 a.m., Guangya Liu wrote:
> > https://github.com/apache/mesos/blob/master/src/master/master.cpp#L4322 also needs
an update
> 
> Alexander Rukletsov wrote:
>     I'm not sure about that one. I think it's more readable how it's now.
> 
> Guangya Liu wrote:
>     I think that you already did some similiar update in hierarchical.cpp, this makes
the code more simple to understand.
>     
>      // First remove the old oversubscribed resources from the total.
>       slaves[slaveId].total = slaves[slaveId].total.nonRevocable();

Done.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40756/#review108250
-----------------------------------------------------------


On Nov. 30, 2015, 10:45 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40756/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2015, 10:45 a.m.)
> 
> 
> Review request for mesos, Ian Downes and Michael Park.
> 
> 
> Bugs: MESOS-4020
>     https://issues.apache.org/jira/browse/MESOS-4020
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/common/http.cpp 692ea3fba2e48e8f8b5257a6bb6ea8a40609013b 
>   src/master/allocator/mesos/hierarchical.cpp 31ed62efb5b1a2edb567f43d37559c5914e0665e

>   src/master/master.cpp b918ae4a0e7dc3cd41165fc4b683ae7b6f031821 
>   src/slave/slave.cpp 9055f2a789cb19f3579c15a379ea505dfef0578c 
> 
> Diff: https://reviews.apache.org/r/40756/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message