mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 40776: Fixed test flakiness in FetcherTest and FetcherCacheTest.
Date Sat, 28 Nov 2015 12:18:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40776/#review108257
-----------------------------------------------------------


Patch looks great!

Reviews applied: [40776]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc;
./support/docker_build.sh

- Mesos ReviewBot


On Nov. 28, 2015, 11:15 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40776/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2015, 11:15 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Till Toenshoff.
> 
> 
> Bugs: MESOS-3579
>     https://issues.apache.org/jira/browse/MESOS-3579
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> GNU tar-1.28 and earlier can relatively randomly misidentify
> compressed files as uncompressed ones, and will then fail when
> unpacking. Avoid compressed tar files in some tests where we know we
> directly call the tar system command (in mesos-fetcher in this case).
> 
> 
> Diffs
> -----
> 
>   src/tests/fetcher_cache_tests.cpp 7fa5e6a572a40dc1a531001fcee2a377d1c99309 
>   src/tests/fetcher_tests.cpp 99c494a2167ea9ec94e63d92980df17a4089f95a 
> 
> Diff: https://reviews.apache.org/r/40776/diff/
> 
> 
> Testing
> -------
> 
> `make check` and verified test does not fail in at least 17500 iterations.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message