mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 40756: Updated codebase to use `nonRevocable()` where appropriate.
Date Fri, 27 Nov 2015 14:49:27 GMT


> On Nov. 27, 2015, 12:54 a.m., Guangya Liu wrote:
> > I think we should also update https://github.com/apache/mesos/blob/master/src/common/http.cpp#L94
> 
> Guangya Liu wrote:
>     It is ok if only want to handle allocator part.

Yeah, we can extend the scope of the update.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40756/#review108177
-----------------------------------------------------------


On Nov. 27, 2015, 2:48 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40756/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2015, 2:48 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4020
>     https://issues.apache.org/jira/browse/MESOS-4020
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/common/http.cpp 692ea3fba2e48e8f8b5257a6bb6ea8a40609013b 
>   src/master/allocator/mesos/hierarchical.cpp 31ed62efb5b1a2edb567f43d37559c5914e0665e

>   src/master/master.cpp 92380952277ae3fe0b535718b6b1b8732e960745 
>   src/slave/slave.cpp 9055f2a789cb19f3579c15a379ea505dfef0578c 
> 
> Diff: https://reviews.apache.org/r/40756/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message