mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Klaus Ma" <klaus1982...@gmail.com>
Subject Review Request 40759: [WIP] Command executor can overcommit the slave
Date Fri, 27 Nov 2015 03:10:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40759/
-----------------------------------------------------------

Review request for mesos, Ben Mahler, Ian Downes, and Vinod Kone.


Summary (updated)
-----------------

[WIP] Command executor can overcommit the slave


Bugs: MESOS-1718
    https://issues.apache.org/jira/browse/MESOS-1718


Repository: mesos


Description (updated)
-------

Currently we give a small amount of resources to the command executor, in addition to resources
used by the command task: https://github.com/apache/mesos/blob/0.20.0-rc1/src/slave/slave.cpp#L2448

```
ExecutorInfo Slave::getExecutorInfo(
    const FrameworkID& frameworkId,
    const TaskInfo& task)
{
  ...
    // Add an allowance for the command executor. This does lead to a
    // small overcommit of resources.
    executor.mutable_resources()->MergeFrom(
        Resources::parse(
          "cpus:" + stringify(DEFAULT_EXECUTOR_CPUS) + ";" +
          "mem:" + stringify(DEFAULT_EXECUTOR_MEM.megabytes())).get());
  ...
}
```

This leads to an overcommit of the slave. Ideally, for command tasks we can "transfer" all
of the task resources to the executor at the slave / isolation level.


Diffs (updated)
-----

  include/mesos/mesos.proto 27971fe 
  src/master/constants.hpp cc38dfc 
  src/master/constants.cpp 98ea7c8 
  src/master/master.hpp 96951e7 
  src/master/master.cpp b918ae4 
  src/slave/constants.hpp bcbb140 
  src/slave/slave.hpp 5ee133a 
  src/slave/slave.cpp 9055f2a 

Diff: https://reviews.apache.org/r/40759/diff/


Testing (updated)
-------

only `make` passwd for now.


Thanks,

Klaus Ma


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message