mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to avoid errors due to double precision errors.
Date Thu, 26 Nov 2015 15:18:06 GMT


> On Nov. 26, 2015, 7:14 a.m., Neil Conway wrote:
> > src/common/resources.cpp, line 951
> > <https://reviews.apache.org/r/40730/diff/1/?file=1147236#file1147236line951>
> >
> >     This definitely needs an explanatory comment.

I'll propose a patch that addresses these issues.


- Bernd


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40730/#review108140
-----------------------------------------------------------


On Nov. 25, 2015, 10:52 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40730/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2015, 10:52 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Klaus Ma, and Neil Conway.
> 
> 
> Bugs: MESOS-3552
>     https://issues.apache.org/jira/browse/MESOS-3552
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> A version of this fix was already proposed by Mandeep Chadha (@mchadha) and submitted
to the reivew board https://reviews.apache.org/r/39056/ . So the main credit should go to
him for this fix.
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp b4abf5405039d7d0a5028ccf034ad2e9623d064c 
> 
> Diff: https://reviews.apache.org/r/40730/diff/
> 
> 
> Testing
> -------
> 
> Added Mandeep's test case to GTEST https://reviews.apache.org/r/39056/ and enabled an
existing precision test (https://reviews.apache.org/r/40732/) to test this fix.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message