mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Mann" <g...@mesosphere.io>
Subject Re: Review Request 40679: Added filtering of CFS cgroup tests.
Date Thu, 26 Nov 2015 10:06:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40679/
-----------------------------------------------------------

(Updated Nov. 26, 2015, 10:06 a.m.)


Review request for mesos, Bernd Mathiske, Marco Massenzio, Till Toenshoff, and Timothy Chen.


Changes
-------

Addressed comments.


Bugs: MESOS-3964 and MESOS-3978
    https://issues.apache.org/jira/browse/MESOS-3964
    https://issues.apache.org/jira/browse/MESOS-3978


Repository: mesos


Description
-------

Added filtering of CFS cgroup tests.


Diffs (updated)
-----

  src/tests/containerizer/cgroups_tests.cpp 2806cf46bc28e9c2ee4245fef26c99e05bdf389c 
  src/tests/containerizer/isolator_tests.cpp 8eaebbcf7fa4ef0c906c2adeb441e64936e6cdf5 
  src/tests/environment.cpp ea70a5f5e752f4855b7b0e19ee3c1a60015a76ea 

Diff: https://reviews.apache.org/r/40679/diff/


Testing
-------

CFS support is disabled by default and must be enabled via a command-line flag. Thus, the
test suite should not assume that this feature is present.

To test, run `sudo make check` on Debian 8 or another linux distribution without CFS cgroup
support.

Mesos should crash during LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs or LimitedCpuIsolatorTest.ROOT_CGROUPS_Cfs_Big_Quota
without this patch, and those tests should be filtered out after this patch. I ran `sudo make
check` on Ubuntu 14.04 and the CFS tests ran like normal, and passed.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message