mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Bannier" <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 40647: Updated centos6.6 installation instructions.
Date Wed, 25 Nov 2015 13:27:02 GMT


> On Nov. 25, 2015, 12:17 p.m., Bernd Mathiske wrote:
> > docs/getting-started.md, line 63
> > <https://reviews.apache.org/r/40647/diff/2/?file=1138857#file1138857line63>
> >
> >     Depending on what grub version you are using, you need this instead:
> >     
> >     sudo sed -i "s/default=1/default=0/g" /boot/grub/grub.conf
> >     
> >     I suggest listing both options with a comment above.

On the platform these instructions apply to `/etc/grub.conf` is a softlink to `/boot/grub/grub.conf`
so we do only need to edit this in one place. I now switched to patching the actual file `/boot/grub/grub.conf`,
though.

A better solution would have been to use some smart grub config editor, like e.g., `grubby`
on centos. However, since we depend on an outside source for the kernel we cannot be sure
about the current revision the install command will get, and so cannot reference the kernel
image that would be installed.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40647/#review107974
-----------------------------------------------------------


On Nov. 25, 2015, 1:26 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40647/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2015, 1:26 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Till Toenshoff, and Timothy Chen.
> 
> 
> Bugs: MESOS-3974
>     https://issues.apache.org/jira/browse/MESOS-3974
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> For full support for the Docker- and MesosContainerizers we require a
> relatively recent kernel. Document this dependency.
> 
> 
> Diffs
> -----
> 
>   docs/getting-started.md 8e1df88fcf9e932dfc01b7455e63553ac028a904 
> 
> Diff: https://reviews.apache.org/r/40647/diff/
> 
> 
> Testing
> -------
> 
> Confirmed that the test succeeds with the suggested change.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message