mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Bannier" <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 40700: Fixed a wrong comparison.
Date Wed, 25 Nov 2015 10:53:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40700/#review107966
-----------------------------------------------------------

Ship it!


The commit should probably be called *Used matching types in comparison*.

- Benjamin Bannier


On Nov. 25, 2015, 10:49 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40700/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2015, 10:49 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-4009
>     https://issues.apache.org/jira/browse/MESOS-4009
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> GCC 5.1 fails to compile if both types in ASSERT_EQ don't match.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp 34d9762a70e906c656c29d1ae48cb0ee0004e60f

> 
> Diff: https://reviews.apache.org/r/40700/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message