mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Timothy Chen" <tnac...@apache.org>
Subject Re: Review Request 39712: Refactor registry client/puller to avoid JSON and struct.
Date Tue, 24 Nov 2015 22:25:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39712/#review107861
-----------------------------------------------------------

Ship it!


Ship It!

- Timothy Chen


On Nov. 24, 2015, 6:52 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39712/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2015, 6:52 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Jojy Varghese, and Timothy Chen.
> 
> 
> Bugs: MESOS-3994
>     https://issues.apache.org/jira/browse/MESOS-3994
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactor registry client/puller to avoid JSON and struct.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 22873276a04941c52e4df41750174c86515f1951

>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 99a421b21cce8311b729689c4c4099206e85dc1f

>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 94b7539b1e1d3b83f0c608d2ac3af9aebbd8b2e6

>   src/tests/containerizer/provisioner_docker_tests.cpp 88b914d3d4a56a51750a75c0988547e2a3e94f56

> 
> Diff: https://reviews.apache.org/r/39712/diff/
> 
> 
> Testing
> -------
> 
> make check(ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message