mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 40396: Quota: Added a test for offer rescinding.
Date Tue, 24 Nov 2015 16:27:24 GMT


> On Nov. 23, 2015, 4:09 a.m., Guangya Liu wrote:
> > src/tests/master_quota_tests.cpp, line 542
> > <https://reviews.apache.org/r/40396/diff/2/?file=1134003#file1134003line542>
> >
> >     Add ASSERT here to make sure no offers?

Could you please elaborate what exactly do you propose?


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40396/#review107546
-----------------------------------------------------------


On Nov. 23, 2015, 10:45 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40396/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2015, 10:45 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, Joseph Wu,
and Qian Zhang.
> 
> 
> Bugs: MESOS-3985
>     https://issues.apache.org/jira/browse/MESOS-3985
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40396/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message