mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 39320: Speeded up the test by reducing the allocation timeout.
Date Tue, 24 Nov 2015 12:39:16 GMT


> On Nov. 23, 2015, 6:45 p.m., Neil Conway wrote:
> > An alternative would be to pause and advance the clock by the allocation_interval.
Do you think that would be worth doing instead?

That's correct. I was not sure what approach is easier to understand. After you input I have
checked the "testing-patterns.md" doc and it looks like clock magic is well documented and
may therefore be a preferred solution. Will update the patch shortly.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39320/#review107625
-----------------------------------------------------------


On Nov. 23, 2015, 5:52 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39320/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2015, 5:52 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Bernd Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3732
>     https://issues.apache.org/jira/browse/MESOS-3732
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/fault_tolerance_tests.cpp 3bbd6cbf6b101415c90991c48f00f33a5aff5590 
> 
> Diff: https://reviews.apache.org/r/39320/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> The run time for the `FaultToleranceTest.FrameworkReregister` test has reduced from more
than `1s` to less than `100ms`.
> Before:
> ```
> [ RUN      ] FaultToleranceTest.FrameworkReregister
> [       OK ] FaultToleranceTest.FrameworkReregister (1018 ms)
> ```
> After:
> ```
> [ RUN      ] FaultToleranceTest.FrameworkReregister
> [       OK ] FaultToleranceTest.FrameworkReregister (49 ms)
> ```
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message