mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 40497: Add hex number support to numify()
Date Tue, 24 Nov 2015 00:43:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40497/#review107683
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/tests/numify_tests.cpp (line 25)
<https://reviews.apache.org/r/40497/#comment166918>

    s/10/10u?



3rdparty/libprocess/3rdparty/stout/tests/numify_tests.cpp (line 39)
<https://reviews.apache.org/r/40497/#comment166919>

    s/16/16u


- Guangya Liu


On 十一月 23, 2015, 10:32 p.m., Cong Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40497/
> -----------------------------------------------------------
> 
> (Updated 十一月 23, 2015, 10:32 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Ian Downes.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> numify() in libprocess uses boost lexical_cast() to cast numbers, but it can not cast
a hex number. This patch adds hex support to numify().
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 5a0ffc38d4194b9f9c53dc1cf0c90ca7bbae2afd

>   3rdparty/libprocess/3rdparty/stout/include/stout/numify.hpp 440181c25d9d132f48c7a4888dc1dbb0157dc6c8

>   3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 14fb644b38a5cbb8cde74aab39e84305f6ab7041

>   3rdparty/libprocess/3rdparty/stout/tests/numify_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40497/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message