> On Nov. 23, 2015, 11:38 p.m., Vinod Kone wrote:
> > src/slave/slave.cpp, line 3040
> > <https://reviews.apache.org/r/40563/diff/2/?file=1135133#file1135133line3040>
> >
> > backticks for `statusUpdate()` ?
There are multiple occurences in the present file that don't use backticks for statusUpdate.
Hence, did not do it.
https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L1311
https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L1835
https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L3080
- Anand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40563/#review107673
-----------------------------------------------------------
On Nov. 21, 2015, 1:45 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40563/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2015, 1:45 a.m.)
>
>
> Review request for mesos, Ben Mahler, Isabel Jimenez, Marco Massenzio, and Vinod Kone.
>
>
> Bugs: MESOS-3476
> https://issues.apache.org/jira/browse/MESOS-3476
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change adds the ability for the agent to handle status updates from HTTP based executors.
Previously, the existing `statusUpdate` method used to handle status updates sent from slave
with `pid == UPID()`, sent from other executors/on behalf of other executors with `pid ==
Some()`. This change modifies the argument to be `Option<PID>`. This ensures that `pid
== None()` when set, the ACK is correctly routed to the corresponding HTTP based executor.
>
>
> Diffs
> -----
>
> src/slave/http.cpp ce48a0584ab18a8d95dd02619f62df18b2276639
> src/slave/slave.hpp ec2dfa99e6b553e2bcd82d12db915ae8625075a1
> src/slave/slave.cpp d1126f00d947fdb4823b0c495335b743254ac7ee
>
> Diff: https://reviews.apache.org/r/40563/diff/
>
>
> Testing
> -------
>
> make check + would add tests once the https://reviews.apache.org/r/39297/ chain is reviewed.
>
>
> Thanks,
>
> Anand Mazumdar
>
>
|