mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 40332: Quota: Implemented recovery in hierarchical allocator.
Date Mon, 23 Nov 2015 22:41:42 GMT


> On Nov. 23, 2015, 9:22 a.m., Qian Zhang wrote:
> > src/master/allocator/mesos/hierarchical.cpp, line 192
> > <https://reviews.apache.org/r/40332/diff/2/?file=1135516#file1135516line192>
> >
> >     I think what we want to use should be master's flag: `slave_reregister_timeout`,
so can we just pass it into allocator when master initializes allocator rather than defining
a separate const here?

Not necessarily. For example, this value may be greater than `slave_reregister_timeout` with
the idea that for an operator may add some agents instead of lost ones. It can also be smaller,
which means we start allocation without waiting for agents to reregister.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40332/#review107568
-----------------------------------------------------------


On Nov. 23, 2015, 4:11 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40332/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2015, 4:11 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, Joseph Wu,
and Qian Zhang.
> 
> 
> Bugs: MESOS-3981
>     https://issues.apache.org/jira/browse/MESOS-3981
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp c65fe35198b846da2dc959dd467a21ff6edd30a9

>   src/master/allocator/mesos/hierarchical.cpp 2765526047767cbd19d13c11ecfa6e90c505b3a7

> 
> Diff: https://reviews.apache.org/r/40332/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message