mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Cong Wang" <cw...@twopensource.com>
Subject Re: Review Request 39417: Add --egress_flow_classifier_parent flag
Date Mon, 23 Nov 2015 22:33:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39417/
-----------------------------------------------------------

(Updated Nov. 23, 2015, 10:33 p.m.)


Review request for mesos, Ian Downes and Jie Yu.


Changes
-------

Address review comments and rebase


Repository: mesos


Description
-------

When --egress_unique_flow_per_container is enabled, we need to install a flow classifier (fq_codel)
qdisc on egress side. This flag specifies where to install it in the hierarchy. By default,
we install it at root. But, for example, if you have already installed HTB qdisc at root,
you may want this to be installed in other place than root, specify an HTB class ID as its
parent here.


Diffs (updated)
-----

  docs/configuration.md 126f4aa8e3de2a2346336991c9b9a2ea61a8cd0a 
  src/Makefile.am a57e46d06c8c26a32a9444be4f0e1269d775f8b0 
  src/linux/routing/handle.hpp 6deff85b52daa6b8771f127fea0d661cb5cd5e6a 
  src/linux/routing/handle.cpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 0865a71b1d79adcf62ca0f12d7ea0a23ebd0e786

  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 09f819685a96cb4785423a5b2303d147719e273e

  src/slave/flags.hpp 0858bdfa93f0c82c9654f9a11d1a251df2d41c36 
  src/slave/flags.cpp 6e8872e435c9a5d895539e3cd47b41f66bc4eb89 

Diff: https://reviews.apache.org/r/39417/diff/


Testing
-------

Manual tests, with and without a pre-installed HTB qdisc and classes.


Thanks,

Cong Wang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message