mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 40512: Libprocess Reinitialization: Add a test-only method to reinitialize libprocess.
Date Mon, 23 Nov 2015 20:14:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40512/
-----------------------------------------------------------

(Updated Nov. 23, 2015, 12:14 p.m.)


Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Changes
-------

Rebase.


Bugs: MESOS-3820
    https://issues.apache.org/jira/browse/MESOS-3820


Repository: mesos


Description
-------

This builds upon earlier changes to complete `process::finalize`.  Tests which need to reconfigure
libprocess, such as some SSL-related tests, can use `process::reinitialize` to do so.  

This method may also be useful for providing additional isolation between tests.


Diffs (updated)
-----

  3rdparty/libprocess/src/openssl.cpp 523b9740a45bdae3fa9a1a1423108e6815fbf872 
  3rdparty/libprocess/src/process.cpp 0fa15dd3d3c83c98411760738b0541248d548ee6 

Diff: https://reviews.apache.org/r/40512/diff/


Testing
-------

Defined `process::reinitialize` in several tests, such as `HTTPTest`, `MetricsTest`, and `ReapTest`
can called `process::reinitialize` before and after tests.  Confirmed that this did not have
side effects on other tests (See https://reviews.apache.org/r/40453/ ).


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message