mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 40264: Libprocess Reinitialization: Implement Clock::finalize for cleaning up timers
Date Mon, 23 Nov 2015 19:57:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40264/
-----------------------------------------------------------

(Updated Nov. 23, 2015, 11:57 a.m.)


Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Changes
-------

Add more comments to document the assumptions of `Clock::finalize`.


Bugs: MESOS-3882
    https://issues.apache.org/jira/browse/MESOS-3882


Repository: mesos


Description
-------

Timers may deference `process_manager`, either directly or via the associated lambda, after
`process_manager` has been freed in `process::finalize`.  Cleaning up the `Clock` appropriately
in `process::finalize` prevents that race.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/clock.hpp 2e526f810e2702b57ea172835ab99e4ee8537252 
  3rdparty/libprocess/src/clock.cpp 7665d120b3897a76ce018bed0c3d039eabca521f 
  3rdparty/libprocess/src/process.cpp 0fa15dd3d3c83c98411760738b0541248d548ee6 

Diff: https://reviews.apache.org/r/40264/diff/


Testing
-------

`make check` (--enable-libevent --enable-ssl)


Thanks,

Joseph Wu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message