mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Qian Zhang" <zhang...@cn.ibm.com>
Subject Re: Review Request 40544: Added quota remove handling.
Date Mon, 23 Nov 2015 08:43:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40544/#review107565
-----------------------------------------------------------



src/master/quota_handler.cpp (line 387)
<https://reviews.apache.org/r/40544/#comment166788>

    I think we need to check if the role is known by master just like what we did for set
quota, and also need to add a TODO to state that we should remove this check once we are able
to dynamically add roles.


- Qian Zhang


On Nov. 22, 2015, 9:35 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40544/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2015, 9:35 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3073
>     https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added quota remove handling.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
> 
> Diff: https://reviews.apache.org/r/40544/diff/
> 
> 
> Testing
> -------
> 
> Test are in the next review.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message