-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38287/#review107558
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38287]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc;
./support/docker_build.sh
- Mesos ReviewBot
On Nov. 23, 2015, 5:37 a.m., Jian Qiu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38287/
> -----------------------------------------------------------
>
> (Updated Nov. 23, 2015, 5:37 a.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, and Paul Brett.
>
>
> Bugs: MESOS-3272
> https://issues.apache.org/jira/browse/MESOS-3272
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_FreezeNonFreezer, the freezer process
is terminated in it initilize method, which causes the core dump when cgroups::freezer::freeze()
calls dispatch(freezer, &internal::Freezer::freeze).
>
> This check is added in cgroups::freezer::freeze() to avoid calling dispatch if the freezer
process is terminated.
>
>
> Diffs
> -----
>
> src/linux/cgroups.cpp f67633e31884b21e943a06100191d2228a637b1a
>
> Diff: https://reviews.apache.org/r/38287/diff/
>
>
> Testing
> -------
>
> ./mesos-tests.sh --gtest_filter="CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_FreezeNonFreezer"
--gtest_repeat=1000 --gtest_break_on_failure
>
>
> Thanks,
>
> Jian Qiu
>
>
|