mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 40242: Improved docs for dynamic reservation HTTP endpoints.
Date Sat, 21 Nov 2015 09:55:56 GMT


> On 十一月 19, 2015, 2:44 a.m., Guangya Liu wrote:
> > docs/reservation.md, line 242
> > <https://reviews.apache.org/r/40242/diff/3/?file=1129368#file1129368line242>
> >
> >     This will not work if end user did not enable autheration, a JIRA ticket is
tracing this MESOS-3940, shall we highlight the issue here before get resolved?
> 
> Neil Conway wrote:
>     I think this is okay -- the issue should be fixed shortly.

I think that we should at least clarify that the dynamic reservation works for both enabling
and not enabling authorization in the document, it is not a MUST we always put <operator_principal>:<password>
in the CURL request, thoughts?


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40242/#review107117
-----------------------------------------------------------


On 十一月 20, 2015, 10:32 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40242/
> -----------------------------------------------------------
> 
> (Updated 十一月 20, 2015, 10:32 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
>     https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Improved docs for dynamic reservation HTTP endpoints.
> 
> 
> Diffs
> -----
> 
>   docs/home.md 7aa785e9ae07f2cc14eb0f1108ae4ab4c8748599 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
> 
> Diff: https://reviews.apache.org/r/40242/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message