mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 39417: Add --egress_flow_classifier_parent flag
Date Sat, 21 Nov 2015 09:49:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39417/#review107485
-----------------------------------------------------------


Bad patch!

Reviews applied: [40497, 40506, 39415, 39416, 39417]

Failed command: ./support/apply-review.sh -n -r 39417

Error:
 2015-11-21 09:49:48 URL:https://reviews.apache.org/r/39417/diff/raw/ [9414/9414] -> "39417.patch"
[1]
error: patch failed: src/slave/containerizer/mesos/isolators/network/port_mapping.cpp:2388
error: src/slave/containerizer/mesos/isolators/network/port_mapping.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 20, 2015, 10:27 p.m., Cong Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39417/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2015, 10:27 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When --egress_unique_flow_per_container is enabled, we need to install a flow classifier
(fq_codel) qdisc on egress side. This flag specifies where to install it in the hierarchy.
By default, we install it at root. But, for example, if you have already installed HTB qdisc
at root, you may want this to be installed in other place than root, specify an HTB class
ID as its parent here.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 126f4aa8e3de2a2346336991c9b9a2ea61a8cd0a 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp e50616fd609588c547c90bba6d7b3b9b3eb4c6a9

>   src/slave/flags.hpp 6ae7c94d2e05d81c8b970e7dcaa82d8aa4de7936 
>   src/slave/flags.cpp 26f554e1a73f1f7f3d7baec7bfc1a7f456c5677c 
> 
> Diff: https://reviews.apache.org/r/39417/diff/
> 
> 
> Testing
> -------
> 
> Manual tests, with and without a pre-installed HTB qdisc and classes.
> 
> 
> Thanks,
> 
> Cong Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message