mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.
Date Fri, 20 Nov 2015 09:28:24 GMT


> On Nov. 18, 2015, 7:51 a.m., Qian Zhang wrote:
> > src/master/quota_handler.cpp, line 180
> > <https://reviews.apache.org/r/40351/diff/3/?file=1128793#file1128793line180>
> >
> >     Why do we want to rescind the offeres that do not contribute to satisfying quota
request?
> 
> Alexander Rukletsov wrote:
>     Because we may rescind more than necessary to satisfy quota request (remember minimal
agent count). If we have a check in place, this will effectively prevent us from doing so.
Does it make sense to you?
> 
> Qian Zhang wrote:
>     Suppose the quota request is to request 20GB disk for a role, and there is an offer
which only include 2 CPU & 2GB memory and has no disk resources at all, so we will rescind
this offer too? This seems a little unfair to me.
>     And can you please clarify a little more about why we want to rescind offers from
at least `numF` agents? The reason is that we want to ensure each framework in that role will
have a chance to get an offer in next allocation cycle?

That's correct, we will rescind that offer and yes, it's a bit unfair. Let me explain why
I decided to remove this check. Suppose we a quota request is for 6 CPUs for role with 3 frameworks.
The first offer we rescind is 10 CPUs, 10GB MEM. Technically, we have enough resources to
satisfy quota, but we would like to rescind offers from at least 2 more agents. Having a check
in place will prevent us from doing so. Do you think greedy rescinding can be a problem?

Yes, we would like to facilitate allocation for each framework in the role, for which quota
is set.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40351/#review106977
-----------------------------------------------------------


On Nov. 19, 2015, 5:15 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40351/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 5:15 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, Joseph Wu,
and Qian Zhang.
> 
> 
> Bugs: MESOS-3912
>     https://issues.apache.org/jira/browse/MESOS-3912
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
> 
> Diff: https://reviews.apache.org/r/40351/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message