mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Conway" <neil.con...@gmail.com>
Subject Re: Review Request 40243: Documented "role" field in Resource protobuf message.
Date Wed, 18 Nov 2015 11:24:57 GMT


> On Nov. 18, 2015, 12:02 a.m., Michael Park wrote:
> > include/mesos/mesos.proto, line 583
> > <https://reviews.apache.org/r/40243/diff/2/?file=1125054#file1125054line583>
> >
> >     How about `The role that this resource is reserved for.`? In the sense that
it's not the role that reserves a resource, per se.

Yes, definitely better!


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40243/#review106962
-----------------------------------------------------------


On Nov. 13, 2015, 12:45 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40243/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2015, 12:45 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
>     https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Documented "role" field in Resource protobuf message.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
>   include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b 
> 
> Diff: https://reviews.apache.org/r/40243/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message