mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joseph Wu" <jos...@mesosphere.io>
Subject Re: Review Request 39889: Windows: Added support for `files/files.hpp`.
Date Tue, 17 Nov 2015 20:59:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39889/#review106930
-----------------------------------------------------------

Ship it!


Double-checked non-Windows build.


src/files/files.hpp (lines 23 - 24)
<https://reviews.apache.org/r/39889/#comment165737>

    I _think_ these headers should be moved down into the lower `#ifdef __WINDOWS__`.


- Joseph Wu


On Nov. 16, 2015, 1:15 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39889/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 1:15 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere,
and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Windows: Added support for `files/files.hpp`.
> 
> 
> Diffs
> -----
> 
>   src/files/files.hpp 818087b13cc787d0bd3186bb3e8a069751629bf9 
> 
> Diff: https://reviews.apache.org/r/39889/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message