mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 40211: Add mesos provisioner doc.
Date Mon, 16 Nov 2015 19:50:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40211/#review106703
-----------------------------------------------------------


I would suggest we have a single doc explaining the whole "unified containerizer" stuff (from
framework API to agent configurations/components), rather than having multiple docs each explaining
one piece of the big pie. Here is what I would suggest for the layout:
```
1. Motivation. Explain why we need 'unified containerizer' and what problem it's solving.
2. Framework API. Explain protobuf like Image, ContainerInfo::MesosInfo::image, Volume::image,
etc.
3. Agent configuration. Explain the command line flags.
4. Internals. Firt, have a figure explaining the interaction between components (e.g., MesosContainerizer,
filesystem isolator, provisioner, image provider, etc). Then, dive into each component in
details and explain its corresponding agent flags.
```


docs/mesos-provisioner.md (line 2)
<https://reviews.apache.org/r/40211/#comment165446>

    After reading the doc, I guess one thing missing here is that we need to have a brief
summary about *why* we need image provisioner and what's its relationship with Mesos containerizer.
    
    I guess we need to include the motivation why we need a unified containerizer here.



docs/mesos-provisioner.md (line 4)
<https://reviews.apache.org/r/40211/#comment165436>

    Can you provide links to App Container Image (ACI) spec and Docker Image spec.
    
    https://github.com/appc/spec/blob/master/spec/aci.md
    
    https://github.com/docker/docker/blob/master/image/spec/v1.md



docs/mesos-provisioner.md (line 7)
<https://reviews.apache.org/r/40211/#comment165448>

    Please briefly explain what is a layer.
    
    Also, please explain how the backend stacks layers into one single root filesystem (e.g.,
copy, overlayfs, bind, etc.)


- Jie Yu


On Nov. 15, 2015, 7:26 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40211/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2015, 7:26 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add mesos provisioner doc.
> 
> 
> Diffs
> -----
> 
>   docs/mesos-provisioner.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40211/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message