mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <>
Subject Re: Review Request 38950: Http Authenticators can be loaded as modules from mesos.
Date Mon, 16 Nov 2015 10:01:37 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Nov. 16, 2015, 11:01 a.m.)

Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff.


Changes to take into account changes in the interface in previous reviews.

Bugs: MESOS-3756

Repository: mesos


Adds support for modularization of HTTP Authenticators. 

It includes an example of how to do it with the Basic HTTP Authenticator.

Diffs (updated)

  include/mesos/authentication/http/basic_authenticator_factory.hpp PRE-CREATION 
  include/mesos/module/http_authenticator.hpp PRE-CREATION 
  src/CMakeLists.txt a14518831553c5eb55fe648d349b91bb55e641d9 
  src/ 92d07c3da897c7664c63e2af91d45921d66f64aa 
  src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION 
  src/examples/test_http_authenticator_module.cpp PRE-CREATION 
  src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 
  src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 
  src/module/manager.cpp f9a0643a70bc9de1484599629041650493842c69 
  src/tests/http_authentication_tests.cpp PRE-CREATION 
  src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2 
  src/tests/module.cpp edab0b37dcf0bd8e15d439726354039c1bbcd51f 



make check


Alexander Rojas

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message