mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 38110: Quota: Checked sanity of quota set requests.
Date Mon, 16 Nov 2015 09:33:01 GMT


> On Nov. 15, 2015, 3:50 p.m., Joris Van Remoortere wrote:
> > src/master/quota_handler.cpp, lines 112-114
> > <https://reviews.apache.org/r/38110/diff/15/?file=1125721#file1125721line112>
> >
> >     Is this really necessary? If so let's add a comment.

I think yes since we do not rely on disconnected or inactive agents. Do you have a different
opinion?


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38110/#review106560
-----------------------------------------------------------


On Nov. 14, 2015, 3:44 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38110/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2015, 3:44 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, Joseph Wu,
and Michael Park.
> 
> 
> Bugs: MESOS-3074
>     https://issues.apache.org/jira/browse/MESOS-3074
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Performs a check whether a quota request is reasonable and can be satisfied at the moment.
A precise answer is impossible here, but a sanity check is still helpful, because it allows
us to filter knowingly unsatisfiable requests.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/38110/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message