mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 40195: Changed commit hook linting to ignore empty diffs.
Date Mon, 16 Nov 2015 09:26:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40195/#review106621
-----------------------------------------------------------


Patch looks great!

Reviews applied: [40131, 40195]

All tests passed.

- Mesos ReviewBot


On Nov. 16, 2015, 8:30 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40195/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 8:30 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere,
and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> On Windows, if you attempt to commit an empty changeset, the commit hooks will
> attempt to lint the entire repository. This is because we pass blank arguments
> to the call to `xargs` that kicks off the C++ linter (e.g., in
> `support/pre-commit`). In the git bash, the default behavior of blank arguments
> is *not* to ignore them, as it is on certain other platforms.
> 
> Thus, we pass the `-r` flag in explicitly to `xargs`, which causes us to ignore
> whitespace-only calls to `xargs`. This will remove the whole-repository linting
> problem altogether.
> 
> 
> Diffs
> -----
> 
>   support/hooks/post-rewrite 7df1e0f29c6ce940a364c0b1d312251c6160e5e3 
>   support/hooks/pre-commit ca9e9810aca921734be5224e3ef71fe7ff4aa03d 
> 
> Diff: https://reviews.apache.org/r/40195/diff/
> 
> 
> Testing
> -------
> 
> Branches tested manually.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message