mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <>
Subject Review Request 40340: [WIP] Windows: Added Windows support to `support/`.
Date Mon, 16 Nov 2015 09:25:41 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, Joseph
Wu, and Marco Massenzio.

Repository: mesos


Windows: Added Windows support to `support/`.

Early draft of the update to the Windows-compatible ``. I'd like to get early
feedback from people in case this is entirely the wrong direction.

At the outset, I will say that the "right way" to do this would be to refactor ``
and `` entirely so that they are more modular (for example, make ``
function-oriented, instead of a pile of statements and expressions, and `` should
be a module proper). I didn't do this the "right way" because it is blocking for our Windows
friends. If it's really important to do this the "right way", we may need to break it into
a couple reviews.

Note that the most questionable part of this is the point at which we redirect `stderr` in
`` to a string capture it for use in ``. This is certainly the quickest
way to do it, but it is not the best -- the best way would be to refactor `` to
be a module, at least, and to handle error logging in a more pluggable way. We aimed for the
shortest diff because there are no tests for any of these scripts, and to be honest, I was
afraid of changing them without tests.


  .gitignore-template 90b6697d19a5e0a68805b23b587b362731a1df25 
  support/ 6890e27f92603b025e25e4db01decf351c33c9a1 
  support/ 66b45692c3c04f68358b63d52e4d87934f241bd7 
  support/ 170be83aa6dca6e8175292169d78e8f7915f7e6e 




Alex Clemmer

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message