mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Clemmer" <>
Subject Review Request 40195: Changed commit hook linting to ignore empty diffs.
Date Mon, 16 Nov 2015 08:30:19 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph

Repository: mesos


On Windows, if you attempt to commit an empty changeset, the commit hooks will
attempt to lint the entire repository. This is because we pass blank arguments
to the call to `xargs` that kicks off the C++ linter (e.g., in
`support/pre-commit`). In the git bash, the default behavior of blank arguments
is *not* to ignore them, as it is on certain other platforms.

Thus, we pass the `-r` flag in explicitly to `xargs`, which causes us to ignore
whitespace-only calls to `xargs`. This will remove the whole-repository linting
problem altogether.


  support/hooks/post-rewrite 7df1e0f29c6ce940a364c0b1d312251c6160e5e3 
  support/hooks/pre-commit ca9e9810aca921734be5224e3ef71fe7ff4aa03d 



Branches tested manually.


Alex Clemmer

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message