mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Artem Harutyunyan" <ar...@mesosphere.io>
Subject Re: Review Request 40241: Fixed apply-reviews.py to prevent git commit editors from hanging.
Date Sat, 14 Nov 2015 17:07:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40241/
-----------------------------------------------------------

(Updated Nov. 14, 2015, 9:07 a.m.)


Review request for mesos, Ben Mahler, Joris Van Remoortere, Joseph Wu, and Vinod Kone.


Summary (updated)
-----------------

Fixed apply-reviews.py to prevent git commit editors from hanging.


Repository: mesos


Description
-------

`subprocess.check_output()` used pipes to capture STDOUT and STDERR. Because of this certain
editors (such as vi) would hang when invoked during git commit. To mitigate that I switched
to `subprocess.call()` and did some code refactoring to accomodate that change.


Diffs
-----

  support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 

Diff: https://reviews.apache.org/r/40241/diff/


Testing
-------


Thanks,

Artem Harutyunyan


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message