mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 39006: stout: Used thread-safe replacement for strerror.
Date Fri, 13 Nov 2015 17:11:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39006/#review106445
-----------------------------------------------------------

Ship it!


Thanks! I'll remove the os/strerror.hpp if os.hpp is already included, per my comment on the
earlier patches.

- Ben Mahler


On Oct. 22, 2015, 7:47 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39006/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2015, 7:47 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3551
>     https://issues.apache.org/jira/browse/MESOS-3551
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Switch call sites to using safe strerror_r wrapper.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/error.hpp 12ba1ca861114e60f8276c0ee91c543abcfc2519

>   3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp dc7c6522b283916b975a77957909f6cdc02944d3

>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/fork.hpp 1baf142d53fd06149c80d4b2677c2a976c05ef71

>   3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp e740d5bc0f0cc5cf8e99b2064c1e39c08282da67

>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 5a1da57f7e27cf8154f0d5f6efd47dcee8a430ff

> 
> Diff: https://reviews.apache.org/r/39006/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message