mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 40241: Fixed a bug with hanging editor reported by Ben Mahler.
Date Fri, 13 Nov 2015 16:29:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40241/#review106429
-----------------------------------------------------------



support/apply-reviews.py (line 95)
<https://reviews.apache.org/r/40241/#comment165163>

    i don't think CalledProcessError is raised for subprocess.call?
    
    don't you want to print the output in case of error?
    
    also, what exactly was the bug? can you add that to the description of this review?


- Vinod Kone


On Nov. 12, 2015, 6:10 p.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40241/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2015, 6:10 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Joris Van Remoortere, Joseph Wu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed a bug with hanging editor reported by Ben Mahler.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 
> 
> Diff: https://reviews.apache.org/r/40241/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message