mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Bannier" <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 39005: stout: Added thread-safe replacement for strerror.
Date Fri, 13 Nov 2015 11:19:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39005/
-----------------------------------------------------------

(Updated Nov. 13, 2015, 11:19 a.m.)


Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.


Changes
-------

Fixed feature test logic (and also made it clearer).


Bugs: MESOS-3551
    https://issues.apache.org/jira/browse/MESOS-3551


Repository: mesos


Description
-------

This commit also adds test cases for os::strerror (from stout) which can
only be committed with a libprocess commit -- the corresponding Makefile
lives there.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/Makefile.am 76e1674e08bbe65a4fdf86731823a61f231d6d12

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 741639a942971e48e2dac42db238d423e61cac21

  3rdparty/libprocess/3rdparty/stout/include/stout/os/strerror.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt 26e1377ee625748b7fdbec327fef9ac602535f83

  3rdparty/libprocess/3rdparty/stout/tests/os/strerror_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39005/diff/


Testing
-------

make check


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message