mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Conway" <neil.con...@gmail.com>
Subject Re: Review Request 40169: [4/7] Added 'Master::authorize{Destroy, Create}Volume' to create/destroy persistent volumes.
Date Fri, 13 Nov 2015 10:52:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40169/#review106396
-----------------------------------------------------------



src/master/master.cpp 
<https://reviews.apache.org/r/40169/#comment165140>

    Seems like this change shouldn't be included in this review. i.e., the state of the tree
after any patch in a patch chain should still be correct.


- Neil Conway


On Nov. 13, 2015, 1:21 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40169/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2015, 1:21 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-3065
>     https://issues.apache.org/jira/browse/MESOS-3065
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added 'Master::authorize{Destroy,Create}Volume' to create/destroy persistent volumes.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 
> 
> Diff: https://reviews.apache.org/r/40169/diff/
> 
> 
> Testing
> -------
> 
> This is the fourth in a chain of 7 patches. `make check` was used to test after all patches
were applied.
> 
> Note that this chain of patches touches many of the same files as another chain beginning
with Review #39985 and ending with Review #39989, which is currently in review as well. To
avoid conflicts, the beginning of this chain begins on top of Review #39989.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message