mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Conway" <neil.con...@gmail.com>
Subject Re: Review Request 40118: [1/7] Added 'principal' field to 'Resource.DiskInfo.Persistence'.
Date Fri, 13 Nov 2015 10:33:59 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40118/#review106393
-----------------------------------------------------------



include/mesos/mesos.proto (line 623)
<https://reviews.apache.org/r/40118/#comment165138>

    Note that this will require changes in the HTTP endpoint patch. (Just observing that whichever
patch gets committed first, the other will need to be updated.)


- Neil Conway


On Nov. 13, 2015, 1:22 a.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40118/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2015, 1:22 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-3064
>     https://issues.apache.org/jira/browse/MESOS-3064
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added 'principal' field to 'Resource.DiskInfo.Persistence'.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
>   include/mesos/v1/mesos.proto e71ddda7f23f2272ce8eb00f358c66fce205c13b 
> 
> Diff: https://reviews.apache.org/r/40118/diff/
> 
> 
> Testing
> -------
> 
> This is the first in a chain of 7 patches. `make check` was used to test after all patches
were applied.
> 
> Note that this chain of patches touches many of the same files as another chain beginning
with Review #39985 and ending with Review #39989, which is currently in review as well. To
avoid conflicts, the beginning of this chain begins on top of Review #39989.
> 
> One additional patch with documentation is forthcoming.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message