mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Mathiske" <be...@mesosphere.io>
Subject Re: Review Request 39800: Fix HDFS du output parsing.
Date Fri, 13 Nov 2015 08:13:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39800/#review106377
-----------------------------------------------------------



src/tests/fetcher_tests.cpp (line 602)
<https://reviews.apache.org/r/39800/#comment165123>

    A comment explaining the WARN message would be good here. Not every hadoop will output
this. My understanding is that you want to make the test resilient to different hadoop installation
conditions. The RR explains this context, but the eventual source code does not.


- Bernd Mathiske


On Nov. 6, 2015, 11:38 a.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39800/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2015, 11:38 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, haosdent huang, and Timothy Chen.
> 
> 
> Bugs: MESOS-3605
>     https://issues.apache.org/jira/browse/MESOS-3605
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - Swallow WARN log messages unless the command failed or we could
>    not parse the output.
>  - Make the actual du output parsing more reliable by not using
>    human-readable format, scanning all the output lines, and
>    tokenizing rather than splitting the output lines.
> 
> 
> Diffs
> -----
> 
>   src/hdfs/hdfs.hpp 18f17231b92b84d0b0e4e15837d0e44ce8758cdf 
>   src/tests/fetcher_tests.cpp 46d0690887b6b6af4c7102753cae8db0a375fa08 
> 
> Diff: https://reviews.apache.org/r/39800/diff/
> 
> 
> Testing
> -------
> 
> make check. Manual testing with a framework that uses the fetcher with HDFS urls.
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message