mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Guangya Liu" <gyliu...@gmail.com>
Subject Re: Review Request 39223: Added Quota Request Validation Tests.
Date Fri, 13 Nov 2015 02:23:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39223/#review106356
-----------------------------------------------------------



src/tests/master_quota_tests.cpp (lines 196 - 198)
<https://reviews.apache.org/r/39223/#comment165090>

    This format may be better? https://github.com/apache/mesos/blob/master/src/tests/resources_tests.cpp#L417-L426



src/tests/master_quota_tests.cpp (lines 228 - 230)
<https://reviews.apache.org/r/39223/#comment165091>

    What about this format? https://github.com/apache/mesos/blob/master/src/tests/resources_tests.cpp#L331-L340



src/tests/master_quota_tests.cpp (lines 260 - 262)
<https://reviews.apache.org/r/39223/#comment165092>

    ditto


- Guangya Liu


On 十一月 12, 2015, 3:22 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39223/
> -----------------------------------------------------------
> 
> (Updated 十一月 12, 2015, 3:22 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3199
>     https://issues.apache.org/jira/browse/MESOS-3199
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see Summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39223/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message