mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Mann" <g...@mesosphere.io>
Subject Re: Review Request 40256: [6/7] Fixed handling of multiple offer operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.
Date Fri, 13 Nov 2015 01:22:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40256/
-----------------------------------------------------------

(Updated Nov. 13, 2015, 1:22 a.m.)


Review request for mesos, Jie Yu, Michael Park, and Neil Conway.


Bugs: MESOS-3065
    https://issues.apache.org/jira/browse/MESOS-3065


Repository: mesos


Description
-------

Fixed handling of multiple offer operations in PersistentVolumeTest.SendingCheckpointResourcesMessage.


Diffs
-----

  src/tests/persistent_volume_tests.cpp 8b791ac0861171b0c655307e965165d9ad7ba966 

Diff: https://reviews.apache.org/r/40256/diff/


Testing (updated)
-------

This is the sixth in a chain of 7 patches. This patch was required in order to fix the `PersistentVolumeTest.SendingCheckpointResourcesMessage`
test, which was broken by the addition of authorization to the `CREATE` and `DESTROY` offer
operations. The test was previously both creating and destroying a persistent volume in a
single `acceptOffer` message. However, our `validate` method for `DESTROY` offer operations
correctly enforces that in order to delete a volume, the volume should be present in the checkpointed
resources of the relevant Agent. This is clearly impossible if the `CREATE` and `DESTROY`
operations are both in the same message.

`make check` was used to test after all patches were applied.

Note that this chain of patches touches many of the same files as another chain beginning
with Review #39985 and ending with Review #39989, which is currently in review as well. To
avoid conflicts, the beginning of this chain begins on top of Review #39989.

There is one more patch with documentation changes forthcoming.


Thanks,

Greg Mann


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message