mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 40252: Consistency fixes on style in src/Makefile.am
Date Fri, 13 Nov 2015 01:08:29 GMT


> On Nov. 12, 2015, 10:06 p.m., Benjamin Bannier wrote:
> > src/Makefile.am, line 1355
> > <https://reviews.apache.org/r/40252/diff/1/?file=1124424#file1124424line1355>
> >
> >     Since you are at it, why not fix this one as well?
> >     
> >     That said, any of this only aligns when tabs are displayed as exactly eight
spaces.

I did a more thorough sweep to fix all the style issues and made indentation consistent.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40252/#review106335
-----------------------------------------------------------


On Nov. 13, 2015, 1:07 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40252/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2015, 1:07 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch fixed style issues in src/Makefile.am. Made indentation consistent throughout.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 09c3d8cb3bcdaca7a061574646da8f51cc2c1698 
> 
> Diff: https://reviews.apache.org/r/40252/diff/
> 
> 
> Testing
> -------
> 
> make distcheck
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message