mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 40167: [2/6] Added ACL protobuf messages 'CreateVolume' and 'DestroyVolume'.
Date Thu, 12 Nov 2015 23:45:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40167/#review106342
-----------------------------------------------------------


Patch looks great!

Reviews applied: [39985, 39986, 39987, 39988, 39989, 40118, 40167]

All tests passed.

- Mesos ReviewBot


On Nov. 12, 2015, 10:54 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40167/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2015, 10:54 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-3065
>     https://issues.apache.org/jira/browse/MESOS-3065
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added ACL protobuf messages 'CreateVolume' and 'DestroyVolume'.
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/authorizer.proto 86bbb45f9d91b4098a262e3e50a793f3bb39497e

> 
> Diff: https://reviews.apache.org/r/40167/diff/
> 
> 
> Testing
> -------
> 
> This is the second in a chain of 6 patches. `make check` was used to test after all patches
were applied.
> 
> Note that this chain of patches touches many of the same files as another chain beginning
with Review #39985 and ending with Review #39989, which is currently in review as well. To
avoid conflicts, the beginning of this chain begins on top of Review #39989.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message