mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 40214: Cleaned up protobuf generation rules in src/Makefile.am.
Date Thu, 12 Nov 2015 18:31:50 GMT


> On Nov. 12, 2015, 5:26 p.m., Vinod Kone wrote:
> > src/Makefile.am, lines 171-177
> > <https://reviews.apache.org/r/40214/diff/1/?file=1123711#file1123711line171>
> >
> >     just curious why we had LOG_PROTOS and STATE_PROTOS pointing to the C files
instead of LOG_PROTO and STATE_PROTO pointing to the proto files?

liblog and libstate need to include those cc and h files. I'll do another cleanup shortly
to consolidate these rules.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40214/#review106271
-----------------------------------------------------------


On Nov. 12, 2015, 1:31 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40214/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2015, 1:31 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Cleaned up protobuf generation rules in src/Makefile.am.
> 
> Probobuf generation rules in src/Makefile.am is a mess. As we introduce more and more
protobuf files in the code base, this will soon become unmaintainable. This is the first phase
of the clean up. The next step is to consolidate all the protobuf generation rules (instead
of copy and paste).
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am d40378f8dc85a3b98d826e6516e17c05cd7ce174 
> 
> Diff: https://reviews.apache.org/r/40214/diff/
> 
> 
> Testing
> -------
> 
> ./configure
> make check
> make install
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message