mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Artem Harutyunyan" <ar...@mesosphere.io>
Subject Re: Review Request 40225: Fixed the Review Board URL in the commit message; substituted subprocess.call_check() with subprocess.call().
Date Thu, 12 Nov 2015 18:08:30 GMT


> On Nov. 12, 2015, 10 a.m., Vinod Kone wrote:
> > support/apply-reviews.py, line 23
> > <https://reviews.apache.org/r/40225/diff/2/?file=1124332#file1124332line23>
> >
> >     s/ui_//
> >     
> >     What's a UI URL?

BenM noticed that instead of putting the Review Board UI URL in the commit message (as in
https://reviews.apache.org/r/40225/) we had a Review Board API URL there (as in https://reviews.apache.org/api/review-requests/40225/).


- Artem


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40225/#review106276
-----------------------------------------------------------


On Nov. 12, 2015, 9:56 a.m., Artem Harutyunyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40225/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2015, 9:56 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Joris Van Remoortere, Joseph Wu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adjusted Review Board URL in comment.
> 
> 
> Diffs
> -----
> 
>   support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589 
> 
> Diff: https://reviews.apache.org/r/40225/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message