mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rukletsov" <ruklet...@gmail.com>
Subject Re: Review Request 39223: Added Quota Request Validation Tests.
Date Wed, 11 Nov 2015 13:42:00 GMT


> On Nov. 3, 2015, 12:35 p.m., Alexander Rukletsov wrote:
> > src/tests/master_quota_tests.cpp, line 463
> > <https://reviews.apache.org/r/39223/diff/6/?file=1105362#file1105362line463>
> >
> >     We try to keep tests atomic: testing one thing at a time. However, I think it
does make sense to merge `Set_InvalidJson`, `Set_InvalidJson2`, and `Set_InvalidResources`
into one tests for brevity and speed. These 3 tests address the same issue: malformed JSON,
similar to what you have done with `Set_InvalidResourceInfos`.
> 
> Joerg Schad wrote:
>     I feel that these are actually testing slightly different stuff (different from the
invalidResource Info)

I think it's fine to have multiple related "test blocks" in a test case, if it is clear where
the problem is when a test fails. Reasons for that are code reusal (less copy-paste code —
less typos, less confusion, easier reviewing, smaller codebase), faster compilation and saving
`SetUp()`, `TearDown()` cycles. 

In this case I think it's fine to have a single test.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39223/#review104894
-----------------------------------------------------------


On Nov. 10, 2015, 10:27 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39223/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2015, 10:27 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3199
>     https://issues.apache.org/jira/browse/MESOS-3199
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see Summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_quota_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39223/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message