> On Nov. 10, 2015, 12:23 p.m., Vinod Kone wrote:
> > support/apply-review.sh, line 5
> > <https://reviews.apache.org/r/40129/diff/1/?file=1121350#file1121350line5>
> >
> > do we even need this script anymore? is this for backwards compatiblity with
existing tooling? is that plan to kill this eventually? worth adding some comments/TODO/JIRA
for this.
Here is the JIRA https://issues.apache.org/jira/browse/MESOS-3885.
`verify_reviews.py` still references apply-review.sh. We should probably give a notice on
dev@ list before removing the script. What do you think?
- Artem
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40129/#review105943
-----------------------------------------------------------
On Nov. 10, 2015, 12:02 a.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40129/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2015, 12:02 a.m.)
>
>
> Review request for mesos, Joris Van Remoortere and Vinod Kone.
>
>
> Bugs: MESOS-3868
> https://issues.apache.org/jira/browse/MESOS-3868
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated apply-review.sh to use apply-reviews.py.
>
>
> Diffs
> -----
>
> support/apply-review.sh 6391451542e9e8847ec38e2ad9d9acf552afead3
>
> Diff: https://reviews.apache.org/r/40129/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Artem Harutyunyan
>
>
|